nuttxpr commented on PR #16254: URL: https://github.com/apache/nuttx/pull/16254#issuecomment-2824332035
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX requirements, but it lacks sufficient detail. Here's what needs improvement: * **Summary:** While it describes the change, it lacks the *why*. Why is this filter functionality necessary? What problem does it solve? What use case does it enable? Be explicit. Also, mention any related NuttX issues. * **Impact:** While it states there's no impact on current implementations, it needs more detail on *user* impact. Even if a BSP doesn't use it yet, *how* would a user utilize this new feature? What configuration options are exposed? Will users need to change their board configuration files? Provide examples. The other impact sections are simply "NO" without justification. Even if there's no impact, briefly explain why (e.g., "Impact on build: NO - This change only modifies driver code and does not affect the build system."). * **Testing:** This is the weakest part. "Tested on SAMv7 custom board" is insufficient. Provide specific details about the build host (OS, compiler version), the exact SAMV7 board and configuration used, and *most importantly,* the actual testing logs *before* and *after* the change. Show how you verified that the filters work as expected (e.g., logs demonstrating the filtered and unfiltered behavior). Without concrete test results, the PR cannot be properly reviewed. In short, the PR provides a good starting point, but needs significantly more detail, especially in the Testing section, to demonstrate that the changes are correct and beneficial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
