nuttxpr commented on PR #16247: URL: https://github.com/apache/nuttx/pull/16247#issuecomment-2821384344
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of *what* is being changed, it lacks crucial information. Here's what's missing: * **Summary:** * **Why:** The summary explains the source of the information (RP2040 datasheet) but not *why* this change is needed. Is the current implementation incorrect? Does it cause bugs? Does it limit functionality? * **What/How:** The summary mentions IRQ priority levels but doesn't specify which part of the code is affected or *how* the change corrects the levels. Which files were modified? What values were changed? * **Related Issues:** Any related NuttX issues or PRs should be linked. * **Impact:** While the impact mentions "correct irq priority levels," it doesn't adequately address the required points. All "NO" or "YES" answers should be followed by a description, even if it's just a brief justification like "No impact on the build process." Specifically, the impact on: * **User:** Will user code need modification? * **Build:** Will the build process or configuration options change? * **Hardware:** Which architectures/boards are affected? Only RP2040-based ones? * **Documentation:** Does this change require documentation updates? If so, were they included in the PR? * **Security:** Could this change have any security implications (even if unlikely)? * **Compatibility:** Does this change break backward compatibility? * **Testing:** * **Build Host(s) and Target(s):** Completely missing. Provide specifics about the environment where testing was performed. * **Testing Logs:** Placeholder logs are present, but actual logs demonstrating the change and verifying the correct functionality *before* and *after* the change are required. Ideally, these logs should clearly demonstrate the incorrect behavior before the change and the corrected behavior after. The PR needs to be significantly more detailed to be considered complete. It needs to explain the *why*, the *how*, and provide concrete evidence that the change works as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
