nuttxpr commented on PR #16222: URL: https://github.com/apache/nuttx/pull/16222#issuecomment-2808373924
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR summary is insufficient. It does not explain *why* the change is necessary (i.e., what problem does it solve? Why is direct access bad?). The testing section is also inadequate. "Built and executed" is not sufficient testing information. What were the expected results? Did the tests pass both before and after the change, verifying the change did not introduce regressions? Provide actual log output, not just a general statement. The Impact section could also benefit from specifically answering each question with NO/YES, even if the answer is NO, for better clarity and consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
