nuttxpr commented on PR #16212: URL: https://github.com/apache/nuttx/pull/16212#issuecomment-2804095217
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements yet, specifically in the Testing section. While the PR author has provided details about their build environment and reproduction steps, the build fails. A successful build and accompanying logs demonstrating the functionality are essential before the PR can be considered complete. Here's a breakdown of what needs to be addressed: * **Build Errors:** The CMake build fails with compilation errors. The logs show: * `rp2040_pico.h: No such file or directory`: This suggests an issue with include paths in the CMake configuration. The build system can't find this required header file. * `'CONFIG_BOARDCTL_UNIQUEID_SIZE' undeclared`: This indicates a missing configuration option. This macro likely needs to be defined either in the board's `defconfig` or passed as a CMake option. * **Missing "Before Change" Logs:** The template requests logs from *before* the change was implemented. These logs are crucial for demonstrating the original behavior and highlighting the improvement introduced by the PR. * **Incomplete Testing:** Even if the build succeeded, the logs don't demonstrate that the CMake build *works as intended*. The PR needs to show that the resulting binary functions correctly on the target hardware. This might involve output from `nsh` or other tests demonstrating the board's functionality. **Recommendations for the PR Author:** 1. **Fix Build Errors:** Address the compilation errors highlighted in the logs. Double-check include directories, macro definitions, and any dependencies required for the Raspberry Pi Pico board. 2. **Provide "Before Change" Logs:** Run the existing build system (presumably Make-based) and capture the output. This establishes a baseline for comparison. 3. **Demonstrate Functionality:** After fixing the build, show that the CMake-built firmware works. Include logs from the target demonstrating successful initialization and operation. Consider adding a simple test application to exercise the core functionality of the board. 4. **Consider Compatibility Issues:** The author mentions compatibility issues preventing full compatibility. These issues need to be explicitly described and, if possible, addressed. If full compatibility isn't achievable yet, explain the limitations and any plans for future improvements. By addressing these points, the PR will better meet the NuttX requirements and be ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
