nuttxpr commented on PR #16176: URL: https://github.com/apache/nuttx/pull/16176#issuecomment-2794043382
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although it could be improved. The summary clearly explains the *why* (broken asserts), *what* (fixing DEBUGASSERTS), and *how* (correcting the conditional logic). The impact section correctly identifies the limited impact. The testing section lists the tested targets, which is good, but is missing the "before" and "after" logs demonstrating the fix. Empty code blocks don't prove anything. Adding actual log output showing the asserts firing before the fix and *not* firing after would significantly strengthen the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
