tmedicci opened a new pull request, #16157:
URL: https://github.com/apache/nuttx/pull/16157

   ## Summary
   
   * arch/xtensa/espressif: Fix ESP32-S2 SPI flash frequency selection
   
   This PR fixes the SPI flash frequency selection for ESP32-S2, enabling the 
Kconfig macros to be selected when ESP32-S2 SoC is enabled. Please note that 
this was recently changed to make it compatible with already existing SPI flash 
Kconfig macros for ESP32 and ESP32-S3 and it introduced this regression for 
ESP32-S2.
   
   ## Impact
   
   Impact on user: YES. Users can select SPI flash frequencies other than 20MHz 
on ESP32-S2.
   
   Impact on build: NO.
   
   Impact on hardware: YES. Enables selecting SPI flash frequencies other than 
20MHz.
   
   Impact on documentation: NO.
   
   Impact on security: NO.
   
   Impact on compatibility: NO.
   
   ## Testing
   
   Build the `esp32s2-saola-1:spiflash` defconfig, selecting multiple SPI flash 
frequency options. Check the boot log to see the actual SPI flash frequency 
being used.
   
   ### Building
   
   ```
   make -j distclean && ./tools/configure.sh esp32s2-saola-1:spiflash && 
kconfig-tweak -e DEBUG_FEATURES && kconfig-tweak -d 
CONFIG_ESPRESSIF_FLASH_FREQ_80M && make olddefconfig && make flash 
ESPTOOL_PORT=/dev/ttyUSB0 -s -j$(nproc) && minicom -D /dev/ttyUSB0
   ```
   
   ### Running
   
   Before this PR:
   ```
   *** Booting NuttX ***
   I (57) boot: chip revision: v0.0
   I (57) boot.esp32s2: SPI Speed      : 20MHz
   I (57) boot.esp32s2: SPI Mode       : DIO
   I (61) boot.esp32s2: SPI Flash Size : 4MB
   ```
   
   After this PR:
   ```
   *** Booting NuttX ***
   I (40) boot: chip revision: v0.0
   I (40) boot.esp32s2: SPI Speed      : 80MHz
   I (40) boot.esp32s2: SPI Mode       : DIO
   I (44) boot.esp32s2: SPI Flash Size : 4MB
   I (49) boot: Enabling RNG early entropy source...
   ```
   
   ### Results
   
   The actual SPI flash frequency previously selected is shown on the boot log 
after this PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to