xiaoxiang781216 commented on code in PR #16154:
URL: https://github.com/apache/nuttx/pull/16154#discussion_r2033208741


##########
arch/arm64/src/Toolchain.defs:
##########
@@ -247,5 +247,11 @@ LDMODULEFLAGS = -r -T $(call 
CONVERT_PATH,$(TOPDIR)/libs/libc/modlib/gnu-elf.ld)
 CELFFLAGS = $(CFLAGS) -fvisibility=hidden -mlong-calls # --target1-abs
 CXXELFFLAGS = $(CXXFLAGS) -fvisibility=hidden -mlong-calls # --target1-abs
 
-LDELFFLAGS = -r -e main
+LDELFFLAGS = -r -e __start

Review Comment:
   the real entry point isn't main in popular libc implementation: 
https://en.wikipedia.org/wiki/Crt0, so the old implementation isn't elegant 
actually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to