nuttxpr commented on PR #16153: URL: https://github.com/apache/nuttx/pull/16153#issuecomment-2784408839
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. Here's why and how to fix it: **Missing or Inadequate Information:** * **Summary:** While the summary explains the "why," it lacks sufficient detail on the "what" and "how." Be explicit about the files modified and the specific code changes made (e.g., "Added `dev/buttons` initialization to `stm32_bringup.c`, mirroring the logic from the `stm32f103c8t6` board support."). * **Impact:** The impact section is too vague. * **User Impact:** Instead of "removed the internal board button...to be used by the user," specify how the user will now configure and access the buttons. Will they need to modify any configuration files? Are there any new command-line options? * **Build Impact:** If no changes to the build process are required, explicitly state "NO." * **Hardware Impact:** Be specific about which STM32 board(s) are affected. Clearly state that the internal button is now disabled in software. * **Documentation Impact:** If documentation needs updating, state "YES" and briefly describe the required updates. If documentation is included in the PR, state "YES - Documentation updated to reflect the new button configuration." * **Security Impact, Compatibility Impact, Anything Else:** Explicitly state "NO" for each if not applicable. * **Testing:** * **Build Host(s) and Target(s):** Provide detailed information about your development environment. Example: "Build Host: Linux (Ubuntu 22.04), x86_64, GCC 11.2.0. Target: STM32F767ZI, nucleo-f767zi config." * **Testing Logs:** The "before" and "after" logs are missing. Include the output of relevant commands (e.g., `buttons` command in NSH) demonstrating the button functionality before and after the changes. The logs should clearly show that the issue is fixed and that the buttons are working as intended. Also, include logs related to the issues you describe with 8 buttons and the built-in button not working correctly. This will help reviewers reproduce and understand the problems. **Unresolved Issues:** The testing section highlights significant unresolved problems. A PR should generally fix bugs, not introduce new ones. Before submitting, you must address the issues with 8 buttons and the built-in button. If you cannot resolve these issues, create separate issues on GitHub and reference them in the PR. **Recommendations:** 1. **Provide detailed information as requested above.** Be explicit and thorough. 2. **Fix the issues with 8 buttons and the built-in button or document them as separate issues.** 3. **Consider creating a separate branch for the changes related to the external buttons and the built-in button issue.** This helps keep the PR focused on the core fix for the original `dev/buttons` problem. 4. **Follow the NuttX coding style and commit message guidelines.** By addressing these points, you'll significantly improve the quality of your PR and increase the likelihood of it being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
