nuttxpr commented on PR #16141: URL: https://github.com/apache/nuttx/pull/16141#issuecomment-2781287421
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change and some testing information, it lacks crucial details. Here's what's missing: * **Summary:** Lacks details on *how* the fix works. What code was changed and in what way? It mentions ADC voltage regulator and start-up time, but doesn't explain the implementation details. It's also missing any related issue references. * **Impact:** Simply stating "RELEASE" is insufficient. It needs to explicitly address *all* the impact points (user, build, hardware, documentation, security, compatibility) with "YES" or "NO" and provide descriptions where applicable. For example, even if the answer is "NO" for most, it should still explicitly state "NO" for each. Since this affects the ADC, there's likely a hardware impact that needs describing. * **Testing:** "CI" is not enough. While CI testing is important, the PR needs to demonstrate *local* testing verification. It should specify the build host OS, CPU, compiler, and the target architecture, board, and configuration used for testing. Furthermore, simply saying "tested on nucleo-c071rb and b-l072z-lrwan1" is insufficient; it needs to include *actual* test logs from *before* and *after* the change to demonstrate the fix. The PR author needs to substantially expand these sections to meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
