JianyuWang0623 commented on code in PR #16094: URL: https://github.com/apache/nuttx/pull/16094#discussion_r2022588281
########## drivers/lcd/st7789.c: ########## @@ -497,6 +497,39 @@ static void st7789_setorientation(FAR struct st7789_dev_s *dev) } #endif +static void st7789_ramctl(FAR struct st7789_dev_s *dev) +{ + /* ============ ==== ==== ====== ====== ======== ===== ====== ====== + * Parameters D7 D6 D5 D4 D3 D2 D1 D0 + * ============ ==== ==== ====== ====== ======== ===== ====== ====== + * 1st (LSB) 0 0 0 RM 0 0 DM1 DM0 + * 2nd (MSB) 1 1 EPF1 EPF0 ENDIAN RIM MDT1 MDT0 + * ============ ==== ==== ====== ====== ======== ===== ====== ====== + */ + + uint16_t ramctl = 0x0; + + st7789_sendcmd(dev, ST7789_RAMCTRL); + st7789_select(dev->spi, LCD_ST7789_SPI_BITS * 2); + + /* Fill the reserved bits */ + + ramctl |= 0xc000; + + /* Set EPF */ + + ramctl |= 0x3000; Review Comment: @michallenc Could you review the fix patch in https://github.com/apache/nuttx/pull/16104 please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org