bskdany commented on code in PR #16087: URL: https://github.com/apache/nuttx/pull/16087#discussion_r2020249013
########## include/nuttx/sensors/ioctl.h: ########## @@ -480,6 +480,30 @@ #define SNIOC_LPF _SNIOC(0x00A0) +/* Command: SNIOC_SET_GAIN + * Description: Sets the gain of the sensor. + */ + +#define SNIOC_SET_GAIN _SNIOC(0x00A1) + +/* Command: SNIOC_SET_SPS + * Description: Set the samples per second of the sensor. + */ + +#define SNIOC_SET_SPS _SNIOC(0x00A2) Review Comment: I choose the SNIOC_SET_SPS over SNIOC_SET_INTERVAL as it's purpose is to interact with the SPS nau7802 registers and not just control the polling interval. I felt that using SNIOC_SET_INTERVAL would have been a way to big side effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
