nuttxpr commented on PR #3044: URL: https://github.com/apache/nuttx-apps/pull/3044#issuecomment-2761305493
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although it could be more thorough. While it addresses the summary and testing sections reasonably well, the impact section lacks detail. It mentions eliminating warnings, which is good, but doesn't fully address all the points. Here's how it could be improved: **Summary:** Good, concisely explains the "why" and the "what". **Impact:** Needs improvement. While it mentions the impact on the build process (eliminating warnings), it doesn't address the other points. Even if the answer is "NO", it should explicitly state that. For example: * **Is new feature added? Is existing feature changed?** NO (bug fix/code cleanup) * **Impact on user:** NO * **Impact on build:** YES (eliminates CMake warnings for versions >= 3.31) * **Impact on hardware:** NO * **Impact on documentation:** Likely NO, but consider if any documentation mentions the previous behavior that generated the warnings. * **Impact on security:** NO * **Impact on compatibility:** NO (unless the removal of the empty strings somehow unexpectedly affects older CMake versions) * **Anything else to consider:** NO **Testing:** Provides some testing information, but could be more specific. Instead of just "unity and nimble," specify the target architecture, board, and configurations used. For example: * **Build Host(s):** (Fill in details about your build host) * **Target(s):** sim:qemu-x86_64, stm32f4discovery:default (Provide examples of the specific targets tested) **Testing logs:** While it mentions logs, it doesn't actually include them. It's crucial to provide *actual* before and after logs demonstrating the warning being eliminated. Even short snippets are better than nothing. By addressing these points, the PR will be significantly stronger and easier for reviewers to assess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
