pussuw commented on code in PR #16031:
URL: https://github.com/apache/nuttx/pull/16031#discussion_r2008078388


##########
arch/risc-v/src/mpfs/mpfs_dsn.c:
##########
@@ -91,9 +98,7 @@ int mpfs_read_dsn(uint8_t *dsn, size_t len)
 
   while ((getreg32(SERVICES_SR) & SCBCTRL_SERVICESSR_BUSY) && --retries > 0)
     {
-      leave_critical_section(flags);
       nxsig_usleep(1000);

Review Comment:
   Or maybe just remove the loop.. the device should be free if the lock is 
available



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to