fdcavalcanti opened a new pull request, #16022:
URL: https://github.com/apache/nuttx/pull/16022

   ## Summary
   
   Modify `types.h` and `inttypes.h` to use the correct `_int32_t` and 
`_uint32_t` types, on Xtensa arch.
   
   This PR solves an issue first mentioned in #15755.
   
   Type is now defined according to recent compiler versions.
   
   On xtensa-esp32-gcc version 8.4.0 we have:
   ```
   #define __INT32_TYPE__ int
   #define __UINT32_TYPE__ unsigned int
   ```
   
   While version 12.2.0 has:
   ```
   #define __INT32_TYPE__ long int
   #define __UINT32_TYPE__ long unsigned int
   ```
   
   Due to this type modification, many logging calls had to be fixed with the 
proper format specifiers: %u, %lu, %ld, etc across arch and board files.
   
   ## Impact
   
   - Impact on user: No.
   - Impact on build: Yes, but all fixes are present in this PR.
   - Impact on hardware: Yes, Xtensa devices only.
   - Impact on documentation: No.
   - Impact on security: No.
   - Impact on compatibility: Yes, improves compatibility since it uses the 
proper int types as specified by the compiler.
   
   ## Testing
   
   Most tests done on Espressif's internal CI. Each build that failed had the 
error fixed, resulting in the commits of this PR.
   Since errors are all logging related, the build system should catch 
everything.
   
   Tested build on all defconfigs for:
   - esp32-devkitc
   - esp32-ethernet-kit
   - esp32-lyrat
   - esp32-pico-kit
   - esp32-wrover-kit
   - esp32s2-saola-1
   - esp32s3-devkit
   - esp32s3-korvo-2
   - esp32s3-lcd-ev


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to