nuttxpr commented on PR #15979: URL: https://github.com/apache/nuttx/pull/15979#issuecomment-2717318550
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX requirements, but could be improved. While it provides a summary of the changes and testing information, it lacks detail in the Impact section. Specifically, it needs to address most of the "NO/YES" questions with more than a single sentence. For example, even though the impact is stated as "only MPFS ethernet," the PR should explicitly state NO for impacts like user changes, build process changes, documentation updates, security implications, etc. If any of these are YES, then a detailed explanation is required. The testing section also needs to include actual logs, not just a description of the test environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
