nuttxpr commented on PR #15975: URL: https://github.com/apache/nuttx/pull/15975#issuecomment-2714561940
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to meet the NuttX requirements, although the testing section could be improved. **Strengths:** * **Clear Summary:** The summary clearly explains the problem, the cause (linking dummy/Kconfig with board Kconfig), and the solution. The example configuration helps illustrate the issue. * **Specific Impact:** The impact section correctly identifies that this is a fix and notes the specific user group affected (those using out-of-tree configurations with upstream boards). * **Concise:** The overall PR description is concise and to the point. **Weaknesses:** * **Insufficient Testing Detail:** While the testing section mentions the configurations tested, it lacks specific details. It should include: * **Build Host(s):** Specify the OS, CPU architecture, and compiler version used for testing. * **Target(s):** Specify the architecture (e.g., stm32) and the specific board configuration used (b-g431b-esc1). Don't just say "out-of-tree configs". Be explicit. * **Logs:** Critically, the testing logs before and after the change are missing. These logs should demonstrate the presence of the warnings before the change and their absence after the change. This is the most crucial evidence that the PR fixes the stated issue. **Recommendation:** To strengthen the PR, add the missing details to the testing section. Provide specific information about the build host and target environments. Most importantly, include the "before" and "after" logs demonstrating the fix. Showing the warnings disappearing after applying the patch will conclusively prove the PR's effectiveness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
