linguini1 commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2708459486
> I implemented the changes. https://github.com/keever50/nuttx/blob/common_wireless_character_driver_API/include/nuttx/wireless/ioctl.h > > **Changes:** > > - Changed SETRADIOFREQ from MHz to Hz 32bit. Because steps of MHz is not precise enough. For example in EU regulations, 869.250MHz would be one of the frequencies that allow 500mW transmission. 868 or 869 have different rules. Allowing Hz instead kHz allows fine tuning. In cases of drift or temperature. > - Added modulation schemes. G/FSK and ASK/OOK. > - Added SET/GET for everything. > - Added void *private to rx_hdr for driver+application specific stuff. > - Changed b8_t fixedmath.h to uint32_t 1/100 steps in rx_hdr. > - Changes lora bandwidth from kHz to Hz, because its possible to have a kHz and a half. > > **Questions** > Why do we have WLIOC_SETADDR under common while it clearly says its driver specific? This sounds like specific packet engine stuff. > > What do we return in rx_hdr when SNR or RSSI is not supported? UINT32_MAX? > These sound good! I can't comment on your second last question, but for the last one I think UINT32_MAX seems reasonable. Why is there a void *private in the rx header? It's a buffer coming from the user, the driver shouldn't need to store anything between calls there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
