nuttxpr commented on PR #15945: URL: https://github.com/apache/nuttx/pull/15945#issuecomment-2700285762
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections. Here's a breakdown of what's missing: * **Summary:** * Missing a clear explanation of *why* the read-only parameter is necessary. What problem does it solve? What use case does it enable? * Lacks a description of *how* the read-only functionality is implemented. What code changes were made to support this? * No mention of related NuttX issues or NuttX Apps issues/PRs, even if none exist (explicitly stating "None" is helpful). * **Impact:** * The impact section is extremely vague. Each "NO" or "YES" needs to be followed by a description, even if it's just "N/A." Specifically, address *all* the listed impact points (user impact, build impact, hardware impact, documentation, security, compatibility). For example, does this change require documentation updates? Does it affect backward compatibility? * The statement "Little fs" under Impact offers no information. * **Testing:** * The provided testing is insufficient. While it shows *how* to test, it doesn't show the *results* of the test. The requirement asks for "Testing logs before change" and "Testing logs after change." Include actual output demonstrating the read-only functionality working (or not working before the change). * Missing details about the build host used for testing. Provide OS, CPU architecture, and compiler information. The target information is slightly better but could be more specific (e.g., "sim:qemu-x86_64:tcpblaster"). In short, the PR needs to be significantly more descriptive and provide concrete evidence of testing and impact assessment to meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
