nuttxpr commented on PR #15941: URL: https://github.com/apache/nuttx/pull/15941#issuecomment-2696812648
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although the testing logs provided are extensive and could be summarized for brevity. Here's a breakdown: * **Summary:** Clearly explains the issue (regression on 64-bit RISC-V due to alignment issues), the affected functionality (booting, potentially other stack-related operations), and the fix's mechanism (although the technical details of the fix itself are absent from this summary). A link to the original commit that introduced the regression would be beneficial. * **Impact:** Addresses all impact categories. Could be strengthened by explicitly stating "NO" for unaffected categories. Specifying the affected architectures (RISC-V 64-bit) more clearly in the hardware impact would be helpful. * **Testing:** Demonstrates testing on relevant platforms (rv-virt:nsh, rv-virt:nsh64, custom mpfs board). The detailed backtrace logs are helpful for verifying the fix but are overly verbose for a PR summary. A concise statement confirming successful boot and operation *after* the fix on the affected platform(s) would be more effective. Mentioning the specific config changes for the backtrace tests is good practice. A summary statement like "Backtrace tests on both rv-virt:nsh and rv-virt:nsh64 successfully captured the expected call stacks after inducing faults in application and interrupt contexts" would suffice. **Recommendations for improvement:** * **Summary:** Include a link to the commit that caused the regression. Briefly describe *how* the fix addresses the alignment issue. * **Impact:** Explicitly mark unaffected categories with "NO". Clarify affected hardware (RISC-V 64-bit). * **Testing:** Replace lengthy backtrace logs with a concise summary of the test results. Focus on demonstrating the fix's effectiveness in resolving the original boot issue. Provide before/after logs showing the boot process, ideally indicating the point of failure before the fix and successful boot after. By addressing these points, the PR will be even stronger and easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
