nuttxpr commented on PR #15938: URL: https://github.com/apache/nuttx/pull/15938#issuecomment-2696110823
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections. Here's a breakdown of what's missing: * **Summary:** * Missing: **Why** was this change necessary? Explain the problem the optimization and fix address. What were the symptoms of the time drift? * Missing: **How** exactly does the optimization work? What specific changes were made to the initialization process? Be precise. * Missing: Links to related NuttX issues, if any. * **Impact:** * While it mentions affected platforms, it needs more specific YES/NO answers to each question, followed by descriptions. For example: * **Is new feature added?** NO * **Is existing feature changed?** YES (Improved timing accuracy of the percpu timer) * **Impact on user:** YES (Applications relying on precise timing from the generic timer will now experience improved accuracy, especially when `USEC_PER_TICKS` is set low.) * **Impact on build:** NO * **Impact on hardware:** YES (ARM64 platforms only) * **Impact on documentation:** MAYBE (If the behavior change regarding timing accuracy is significant, the documentation may need updates.) Consider if documentation should mention optimal `USEC_PER_TICKS` settings for certain platforms. * **Impact on security:** NO (unless the time drift had security implications, which should be explicitly stated) * **Impact on compatibility:** Potentially YES. Even if it's a bug fix, state whether this fix might break any existing code that relied on the previous (inaccurate) behavior. If not, explicitly state NO and justify it. * **Testing:** * Insufficient detail about the build host. Specify the OS version, compiler version (e.g., GCC 12.2.1), etc. * "QEMU/aarch64-qemu-virt and IMX8QM-MEK" is not descriptive enough. Specify the configurations used. For example: `qemu-system-aarch64 -M virt -cpu cortex-a53 -nographic -kernel nuttx.bin` and similarly for the IMX8QM-MEK. * **Completely missing the "Testing logs before change" and "Testing logs after change" sections.** This is critical. Show specific commands used for testing and the output that demonstrates the problem before the change and the improved behavior after the change. Quantify the improvement. For example, show the time drift before and the accuracy after the fix. In short, the PR description needs to be significantly expanded to meet the NuttX requirements. Provide the missing details and specific examples in the testing logs to demonstrate the effectiveness of the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
