linguini1 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2695537909
> @linguini1 I see that you added common IOCTL commands, however i would suggest looking at https://github.com/apache/nuttx/issues/15856 maybe. The common API is still being worked on. I just started implementing the features into ioctl.h > Maybe you can look at that? It is fine if you want to do it yourself too while you are at it. > The main difference between my common IOCTL and yours is i tagged LoRa related commands with WLIOC_LORA_x. > This is done to keep some seperation between two obviously different command groups. > Personally it feels "messy" when all modulation types are considered common. > Hey yeah, I did see that discussion and I like some of the solutions proposed there. However, I don't want to start implementing the API from that discussion in this PR since I know it is still under discussion (I have some ideas to discuss as well). My plan was just to merge this prototype (marked as EXPERIMENTAL) and then make changes to it once we have a better idea of a fleshed out API. I'm willing to commit to making those changes in another PR along with changing the sx17x legacy driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
