nuttxpr commented on PR #15922: URL: https://github.com/apache/nuttx/pull/15922#issuecomment-2693126991
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While the summary is acceptable, the impact and testing sections are insufficient. Here's why and how to fix it: * **Impact:** While the code changes might not affect functionality, the documentation impact should be marked as "YES" and described as "Fixes typos in code comments for `chip.h`, `allocateheap.c`, and `start.c`." This explicitly acknowledges the improvement to the documentation. * **Testing:** While exhaustive testing may not be *required*, claiming *no* testing was done is misleading. At a minimum, the PR should state that the changes were visually inspected to confirm the typos were corrected and no new issues were introduced. Ideally, the PR author should have recompiled the affected code to ensure the changes didn't break the build process (even comment changes can sometimes cause unexpected issues). A brief statement confirming successful compilation on at least one platform should be included. For example: ``` Testing: Build Host: macOS, Apple M1, clang-14 Target: sim:nsh Changes were visually inspected and the code recompiled successfully for the sim:nsh configuration to confirm no build errors were introduced. ``` By addressing these points, the PR will better adhere to the NuttX requirements and provide more confidence in the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
