nuttxpr commented on PR #3005:
URL: https://github.com/apache/nuttx-apps/pull/3005#issuecomment-2674362801

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   No.  The PR description lacks crucial information required by the NuttX 
guidelines.  While it addresses some sections, it's far too brief and doesn't 
provide the necessary details.
   
   Here's what's missing:
   
   * **Summary:**  Needs a more detailed explanation. "Relative file path does 
not match actual file" is a symptom, not a description of the *why*, *what*, 
and *how*. What file path is incorrect?  Where is it used? How was it fixed? 
What part of the code was changed? Any related NuttX issues?
   * **Testing:** "local" is insufficient.  Provide specifics about the build 
host (OS, CPU architecture, compiler version) and the target platform 
(architecture, board, configuration). Include *actual* testing logs before and 
after the change to demonstrate the fix.  Just stating that it works isn't 
enough.
   
   
   Without these details, it's impossible to determine if the PR truly meets 
the requirements.  The current description makes it difficult to review and 
understand the changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to