nuttxpr commented on PR #15887: URL: https://github.com/apache/nuttx/pull/15887#issuecomment-2674291687
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR is missing crucial information required by the NuttX guidelines. While it states *what* is fixed, it fails to explain *how* it is fixed and provides no context. Here's what's missing: * **Summary:** * Lacks a description of the functional part of the code being changed. *Where* is this relative file path? In a specific driver? A core OS component? An app? * Missing explanation of *how* the fix works. What was the incorrect behavior, and what change corrects it? * No related issue references, even if none exist, it should explicitly state "N/A" or "None". * **Testing:** * "local" is insufficient. Needs specifics of the build host (OS, CPU, compiler) and target (architecture, board, configuration). * Absolutely requires "before" and "after" testing logs demonstrating the faulty behavior and the fix. Empty code blocks are unacceptable. The PR author needs to substantially revise their submission to meet the requirements. They need to provide the missing context and details to allow reviewers to properly assess the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
