jlaitine commented on PR #15878: URL: https://github.com/apache/nuttx/pull/15878#issuecomment-2673992811
The deadlocking issue didn't occur with the upstream version; it only happens with this patch integrated into older versions of nuttx, which still use the global spinlock "spin_lock_irqsave(NULL)" in modifyreg32 and also in interrupt logic (irq_attach). As the register modifications in mpfs_plic.c are already protected by a spinlock, I just changed the modifyreg32 into separate getreg32 and putreg32 calls. This saves some unnecessary spinlock code execution and is also compatible with our older branches. This is now re-tested, and marking as ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
