hartmannathan commented on PR #15847:
URL: https://github.com/apache/nuttx/pull/15847#issuecomment-2672036848
OK, I went through all the new nxstyle reports.
The good news: I didn't see any regressions, meaning that errors that
nxstyle reported previously are still being reported.
The slightly not-so-good news: We seem to be picking up words like `switch`
when they occur in a substring like `switch_needed` or `switching`.
One more comment: Most of the new "Missing whitespace after keyword" errors
are related to things like this:
```
#ifdef CONFIG_PM
static void up_pm_notify(struct pm_callback_s *cb, int domain,
enum pm_state_e pmstate)
{
switch (pmstate)
{
case(PM_NORMAL):
{
/* Logic for PM_NORMAL goes here */
}
break;
case(PM_IDLE):
{
/* Logic for PM_IDLE goes here */
}
break;
case(PM_STANDBY):
{
/* Logic for PM_STANDBY goes here */
}
break;
case(PM_SLEEP):
{
/* Logic for PM_SLEEP goes here */
}
break;
default:
/* Should not get here */
break;
}
}
#endif
```
I haven't looked further into why `PM_NORMAL` and the others are in
parenthesis. Perhaps the parenthesis should be moved to the macro definitions?
I don't know... that will take more research that is outside the scope of this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
