nuttxpr commented on PR #15876: URL: https://github.com/apache/nuttx/pull/15876#issuecomment-2670406596
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does not fully meet the NuttX requirements yet, specifically in the Testing section. While the testing logs *before* the change are provided, the logs *after* the change are missing, replaced with "tbd, currently crashes". This indicates the change introduced a critical bug and is not ready to be merged. Here's a breakdown of what needs to be addressed: * **Testing:** The most crucial aspect is fixing the crash. The PR cannot be considered until the functionality works as intended. Once fixed, provide complete testing logs *after* the change. Ideally, these logs should demonstrate the expected improvement in context switching overhead. Consider including timings or performance metrics to quantify the impact of the change. The current logs only show memory usage, which is not directly relevant to demonstrating the benefits of LAZYFPU. * **Impact:** While the impact description mentions reduced context switching overhead, it lacks specifics. Quantify the performance improvement. For example, "Reduces context switching overhead by X% in the FPU test case". Also, the limited testing on STM32H7 only is acknowledged. While understandable, the PR should ideally strive for broader testing, or at least outline a plan for how compatibility with other ARMv7-M chips will be verified in the future. * **Summary:** The summary is good. However, specifying the magnitude of the context switching overhead reduction (once quantified through testing) would make it even stronger. In short, this PR needs further work and testing before it can be merged. The primary focus should be on resolving the crash and then providing comprehensive testing data demonstrating the benefits of the LAZYFPU implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
