linguini1 commented on code in PR #15828:
URL: https://github.com/apache/nuttx/pull/15828#discussion_r1957350903
##########
include/nuttx/wireless/ioctl.h:
##########
@@ -60,13 +60,31 @@
/* output power (in dBm) */
#define WLIOC_GETTXPOWER _WLCIOC(0x0006) /* arg: Pointer to int32_t, */
/* output power (in dBm) */
+#define WLIOC_SETBANDWIDTH _WLCIOC(0x0007) /* arg: Pointer to uint32_t, */
+ /* bandwidth in Hz */
+#define WLIOC_GETBANDWIDTH _WLCIOC(0x0008) /* arg: Pointer to uint32_t, */
+ /* bandwidth in Hz */
+#define WLIOC_SETSPREAD _WLCIOC(0x0009) /* arg: Pointer to uint8_t, */
+ /* spread factor */
+#define WLIOC_GETSPREAD _WLCIOC(0x000a) /* arg: Pointer to uint8_t, */
+ /* spread factor */
+#define WLIOC_GETSNR _WLCIOC(0x000b) /* arg: Pointer to int8_t, */
+ /* signal to noise ratio */
+#define WLIOC_SETPRLEN _WLCIOC(0x000c) /* arg: uint16_t, */
+ /* preamble length */
+#define WLIOC_GETPRLEN _WLCIOC(0x000d) /* arg: Pointer to uint16_t, */
+ /* preamble length */
+#define WLIOC_SETMOD _WLCIOC(0x000e) /* arg: enum, */
+ /* modulation type */
+#define WLIOC_GETMOD _WLCIOC(0x000f) /* arg: char[10] pointer, */
+ /* modulation type */
Review Comment:
The thing is that they are all called `SX127XIOC_*`. I think that would look
confusing to be used on the RN2xx3. That's why I don't think there really
should be different naming for "device specific" ioctl commands since they can
be re-used by other devices that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
