michallenc opened a new pull request, #15812:
URL: https://github.com/apache/nuttx/pull/15812

   ## Summary
   Function `w25qxxxjv_erase` wasn't correctly handling an error in 
`w25qxxxjv_erase_sector` call and was returning success even on failure. 
Moreover this change does not return `EBUSY` but waits for the previous 
operation to finish. Returning `EBUSY` doesn't make much sense here as we 
approximately know how long to wait based on flash's parameters.
   
   ## Impact
   
   This fixes wrong error handling and ensures the erase waits for previous 
operation to finish.
   
   ## Testing
   
   Tested on SAMv7 custom board with W25Q512 and W25Q01 flashes (512 Mbits and 
1 Gbit, the latter has two dies, so slightly different behavior). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to