nuttxpr commented on PR #15793: URL: https://github.com/apache/nuttx/pull/15793#issuecomment-2645990483
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR likely does *not* meet the NuttX requirements. Here's why: * **Insufficient Summary:** The summary is vague. It doesn't explain *why* these changes are necessary (bug fix, new platform support, etc.), *what* functional parts of the code were changed, or *how* the changes work. Simply saying "copied from MAX32660" isn't enough. Details about the specific modifications are crucial. * **Unclear Impact:** Claiming "no impact" is unlikely given the amount of modification. Even if it doesn't break the MAX32660 port, there could be unforeseen consequences. The PR needs to specifically address *all* impact areas (build, hardware, documentation, security, compatibility). For a new port like the MAX32690, many of these should be "YES". * **Inadequate Testing:** Testing only if it "breaks" another port isn't sufficient. The PR must demonstrate that the MAX32690 port itself is functional. "Works as intended" requires detailed test logs showing the specific functionality tested on the MAX32690 *before* and *after* the changes. The logs provided are placeholders. **To make this PR acceptable, the author needs to:** 1. **Rewrite the Summary:** Provide a clear explanation of the changes, their purpose, and how they work. Specifically mention that this adds support for the MAX32690. 2. **Thoroughly Address Impact:** Analyze and document the impact on *all* listed areas. Adding support for a new platform has significant impact. 3. **Provide Real Test Logs:** Demonstrate the functionality of the MAX32690 port both before (likely showing it doesn't work) and after (showing the functionality added). Include specifics like which peripherals and drivers are being tested. 4. **Clean Up the Code:** "Messy code copied from elsewhere" isn't acceptable. Code needs to be properly reviewed, styled, and commented before submission. In short, this PR needs substantial revision before it can be considered. The current state suggests a work in progress, not something ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
