acassis commented on code in PR #15780: URL: https://github.com/apache/nuttx/pull/15780#discussion_r1946564408
########## include/nuttx/serial/serial.h: ########## @@ -283,6 +283,22 @@ struct uart_ops_s FAR const void *buf, size_t len); }; +/* This structure is used for U(S)ART frame, overrun, parity and brk error + * counters. This way applications will know if the UART communition is + * having some trouble. + */ + +#ifdef CONFIG_SERIAL_TIOCGICOUNT Review Comment: My initial idea was to avoid creating a struct when it wasn't necessary, but I agree, this code doesn't need this this new config. The compilation will remove it case not used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org