nuttxpr commented on PR #15745: URL: https://github.com/apache/nuttx/pull/15745#issuecomment-2629407216
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. Here's why: * **Insufficient Summary:** While the summary explains *what* changed, it lacks *why* the change was necessary (besides performance). Was there a bug report or feature request driving this change? A link to a related issue is highly recommended. The "functional part" being changed is vaguely described as "nxgdb memleak command". More detail is needed, such as the specific file and function(s) modified. * **Incomplete Impact Assessment:** The impact section only addresses performance. While important, it omits several required considerations: * **Impact on user:** Even if the answer is "NO", it needs to be explicitly stated. * **Impact on build:** Explicitly state "NO" if there is no impact. * **Impact on hardware:** Explicitly state "NO" if there is no impact. * **Impact on documentation:** Does this change require documentation updates? If not, state "NO". * **Impact on security:** Explicitly state "NO" if there is no impact. * **Impact on compatibility:** Explicitly state "NO" if there is no impact. * **Insufficient Testing Information:** "Tested internally with a coredump" is not adequate. Provide details about the build host and target (architecture, board, configuration). Include relevant snippets of the *before* and *after* testing logs demonstrating the 35% performance improvement. Simply stating the improvement without evidence is not convincing. If the testing is based on a private project, consider creating a minimal reproducible example that can be shared. "Internal testing" generally isn't acceptable for open-source contributions. **To improve the PR:** 1. Expand the summary to explain the motivation for the change and precisely identify the affected code. Link to any relevant issues. 2. Thoroughly complete the Impact section, explicitly addressing all points, even if the answer is "NO". 3. Provide detailed testing information, including host and target details, and relevant *before* and *after* logs demonstrating the claimed performance improvement. Create a shareable test case if possible. Consider including details about how the 35% performance improvement was measured. 4. Follow the [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md) precisely. By addressing these points, the PR will be much more likely to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
