nuttxpr commented on PR #15694: URL: https://github.com/apache/nuttx/pull/15694#issuecomment-2614278367
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR meets the NuttX requirements. While the provided summary is good, it could be slightly improved by explicitly mentioning the *why*. Something like: "This change is necessary to enable building kernel modules with Kernel mode NuttX in exported SDK builds. Currently, missing LDMODULEFLAGS and incorrect LDELFFLAGS cause link errors..." The Impacts section could be more detailed following the template. Specifically, address each point: * **Is new feature added? Is existing feature changed?**: Existing feature (module building) fixed. * **Impact on user**: YES. Users building kernel modules with exported SDK will now be able to do so successfully. * **Impact on build**: YES. LDMODULEFLAGS are now exported and LDELFFLAGS corrected. * **Impact on hardware**: NO. * **Impact on documentation**: Potentially YES. If documentation exists regarding building modules with exported SDK, it should be updated. If not, consider adding documentation. * **Impact on security**: NO. * **Impact on compatibility**: YES. Improves forward compatibility with exported SDK builds. Mention if any backward compatibility concerns exist (unlikely). * **Anything else to consider?**: None apparent. The Testing section is generally adequate but could benefit from more specific details. Instead of "local checks," specify OS, compiler version, NuttX configuration. For example: "Build Host: Linux, GCC 12.2, NuttX configured for qemu-armv7a with Kernel mode and EXAMPLES_MODULE enabled." Similarly, be more explicit with the Target details: "Targets: qemu-armv7a:nsh and qemu-armv7a:knsh." Including snippets of the *actual* before/after testing logs (even if short and illustrative) would strengthen the verification claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
