nuttxpr commented on PR #2977: URL: https://github.com/apache/nuttx-apps/pull/2977#issuecomment-2614266730
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR likely **does NOT meet** the NuttX requirements, despite claiming to pass CI. ## Summary The provided summary is insufficient. It lacks crucial information like: *why* the `apps/testing` reorganization is necessary, *what* exactly changed within the `apps/testing` directory, and *how* the reorganization works. Simply stating "apps/testing reorg" doesn't explain the purpose or the technical details of the change. Issue/PR references are also missing. ## Impact While "apps/testing reorg" hints at an impact on the apps, it doesn't adequately address the required details. The PR author needs to specify YES/NO for each impact category and provide descriptions where applicable. For example, even if user impact is NO, they should explicitly state NO. For a reorganization, documentation impact is likely YES, requiring explanation of the new structure. Build impact might also be YES if build scripts or dependencies changed. The current response ignores these details. ## Testing "pass ci" is inadequate. While CI passing is good, the requirement is to demonstrate local verification *before* submitting the PR. This means specifying the host and target environments and providing actual log output demonstrating the issue before the change and the successful operation after the change. Just stating "pass ci" avoids demonstrating personal due diligence and makes it difficult to understand what was actually tested. In short, this PR needs substantial improvement in providing the necessary information before it can be considered for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
