nuttxpr commented on PR #2978: URL: https://github.com/apache/nuttx-apps/pull/2978#issuecomment-2614266321
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides some information, it lacks crucial details. Here's a breakdown of what's missing: * **Insufficient Summary:** "testing: Move..." isn't descriptive enough. *Why* are these moves necessary? What problem do they solve? What functionality changes? How do the moves work (e.g., code adaptations, dependencies)? Are there related NuttX issues? * **Incomplete Impact Assessment:** "test folder reorg" is too vague. While it might not impact users directly, it could affect build processes, documentation (if any existed for the old location), and potentially compatibility for test suites. Each "Impact" point needs a proper "NO" or "YES" followed by a description if "YES." * **Insufficient Testing Details:** "pass ci" is not enough. What specific build hosts and targets were tested? Providing OS, CPU architecture, compiler details is crucial for reproducibility. More importantly, there are no "Testing logs before change" and "Testing logs after change." Simply stating that CI passed doesn't show *what* was tested or *how* the changes improved the situation. Show concrete examples of the problem before and the solution after. This PR needs to be significantly more detailed to be considered acceptable. Provide the missing context and evidence for each section to demonstrate the value and correctness of the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
