nuttxpr commented on PR #2976: URL: https://github.com/apache/nuttx-apps/pull/2976#issuecomment-2614261097
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## Summary This PR appears to be missing crucial information required by the NuttX guidelines. The summary doesn't explain the *why*, *what*, or *how* of the change. It only mentions "testing folder restructure," which is insufficient. There's no mention of related issues or pull requests either. ## Impact While the impact section mentions "testing folder restructure," it fails to address the specific impact questions. Does this change add/modify features? Does it affect users, the build process, hardware, documentation, security, or compatibility? Simply saying "testing folder restructure" isn't helpful without context. ## Testing "Pass CI" is also insufficient. While CI passing is good, the PR needs to specify the build hosts and targets tested. It also needs to provide *actual* testing logs from *before* and *after* the change, not just a statement that the CI passed. Without these logs, reviewers cannot verify the impact of the changes. **In short, no, this PR does not meet the NuttX requirements.** It needs significantly more detail in all sections to be considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
