anchao commented on PR #15684: URL: https://github.com/apache/nuttx/pull/15684#issuecomment-2611626180
I still don't like the `raw_` prefix. In Linux, the semantics of raw_ is to bypass `spinlock_check`, and in the Linux `PREEMPT_RT` patch, **spin_lock has removed the logic of disabling preemption**. Why do we still have to implement such an outdated solution? enable CONFIG_PREEMPT_RT: https://github.com/torvalds/linux/blob/master/include/linux/spinlock_rt.h#L96-L101  My suggestion is, 1. Remove the sched_lock logic from all spin_locks 2. raw_spin_lock retains sched_lock 3. Add spin_lock _notrace version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
