nuttxpr commented on PR #15683: URL: https://github.com/apache/nuttx/pull/15683#issuecomment-2611395411
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the issue and indicates testing through CI, it lacks crucial information. Here's what's missing: * **Summary:** Needs more detail. *Why* was there a compile error? *How* was it fixed? What exactly changed in the code? A link to the related NuttX issue should be included. * **Impact:** While stating "none" is acceptable if truly no impact, it's unlikely a compile error fix has *zero* impact. At minimum, the build process was previously broken and is now fixed, so "Impact on build: YES (Fixed compile error that prevented successful build)" is more appropriate. * **Testing:** "CI" is insufficient. While CI testing is important, the PR should demonstrate *local* testing verification. This requires specifying the build host and target environment, along with providing *specific* "before" and "after" testing logs demonstrating the fix. Simply saying "compile error" doesn't show that the intended functionality now works correctly. Show the previous error message and the successful compilation/execution after the fix. The submitter needs to expand on these sections to meet the NuttX PR requirements. A more complete example would be beneficial for reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
