michallenc commented on code in PR #15649: URL: https://github.com/apache/nuttx/pull/15649#discussion_r1925327844
########## drivers/bch/bchdev_driver.c: ########## @@ -435,6 +435,15 @@ static int bch_ioctl(FAR struct file *filep, int cmd, unsigned long arg) break; #endif + case BIOC_DISCARD: Review Comment: Good catch. Yes if we have `CONFIG_FTL_READAHEAD` option set on (which I did not, so it passed my tests). Should be fixed now, had to add `rwb_discard` function for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org