JianyuWang0623 commented on code in PR #15641:
URL: https://github.com/apache/nuttx/pull/15641#discussion_r1925192400


##########
drivers/rpmsg/rpmsg_port_uart.c:
##########
@@ -216,7 +216,7 @@ rpmsg_port_uart_send_connect_req(FAR struct 
rpmsg_port_uart_s *rpuart)
   ssize_t ret = file_write(&rpuart->file, &ch, 1);
   if (ret != 1)
     {
-      rpmsgerr("Send connect request failed, ret=%d\n", ret);
+      rpmsgerr("Send connect request failed, ret=%zu\n", ret);

Review Comment:
   I have a question, why not using "%zd" as `file_write()` may return negative 
`errno`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to