xiaoxiang781216 commented on code in PR #2961: URL: https://github.com/apache/nuttx-apps/pull/2961#discussion_r1922973349
########## testing/driver/monkey/Make.defs: ########## @@ -1,5 +1,5 @@ ############################################################################ -# apps/testing/monkey/Make.defs +# apps/testing/driver/monkey/Make.defs Review Comment: monkey is more like a command line, let's move to testing/tools/ or testing/utils ########## testing/driver/irtest/cmd.cxx: ########## @@ -1,5 +1,5 @@ /**************************************************************************** - * apps/testing/irtest/cmd.cxx + * apps/testing/driver/irtest/cmd.cxx Review Comment: irtest is more like a command tool, so it's better to move testing/tools or testing/utils ########## testing/driver/sensortest/sensortest.c: ########## @@ -1,5 +1,5 @@ /**************************************************************************** - * apps/testing/sensortest/sensortest.c + * apps/testing/driver/sensortest/sensortest.c Review Comment: it's more like a command line tool, let's move to testing/tool or testing/utils ########## testing/driver/sd_bench/Makefile: ########## @@ -1,5 +1,5 @@ ############################################################################ -# apps/testing/sd_bench/Makefile +# apps/testing/driver/sd_bench/Makefile Review Comment: benchmark shold move to apps/benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
