nuttxpr commented on PR #2959: URL: https://github.com/apache/nuttx-apps/pull/2959#issuecomment-2601976247
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. While it provides a basic summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it states the "what," it lacks the "why." Why is this restructuring necessary? Is it for better organization, future expansion, or some other reason? How exactly does moving these folders achieve that goal? * **Impact:** The impact section is too brief. It mentions the new folder and moved folders, but fails to address the specific points required. For all of the "Impact on..." items, explicit "YES" or "NO" answers are needed followed by descriptions where applicable. Even if the answer is "NO," explicitly stating so is essential for clarity. For example: * Impact on user: NO * Impact on build: YES (Build scripts and paths may need to be updated to reflect the new directory structure. This could affect users who have custom build configurations.) * Impact on hardware: NO * ... and so on for all other impact categories. * **Testing:** Saying "ci test" is insufficient. Provide specific details: * **Build Host(s):** Specify the operating system, CPU architecture, and compiler version used for testing. (e.g., Linux x86_64, GCC 12.2) * **Target(s):** Specify the target architecture, board, and configuration used for testing. (e.g., `sim:nsh`, `stm32f4discovery:nsh`) * **Testing logs:** Provide actual log snippets demonstrating the functionality before and after the change. Even if there's no functional change, show some output proving that the affected tests still run successfully in the new location. If there is expected output, show that. In short, the PR description needs to be significantly more detailed and address all the required points explicitly. Providing more context and concrete evidence will make the review process much smoother and ensure the change is well-understood. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
