Re: [PR] fs/vfs: initialize uio only if lower implement readv/writev [nuttx]

[via GitHub]

anchao commented on code in PR #15603:
URL: https://github.com/apache/nuttx/pull/15603#discussion_r1921702377


##########
fs/vfs/fs_read.c:
##########
@@ -50,19 +50,16 @@
  *
  ****************************************************************************/
 
-static ssize_t file_readv_compat(FAR struct file *filep, FAR struct uio *uio)
+static ssize_t file_readv_compat(FAR struct file *filep,
+                                 FAR const struct iovec *iov, int iovcnt)
 {
-  FAR const struct iovec *iov = uio->uio_iov;
-  int iovcnt = uio->uio_iovcnt;
   FAR struct inode *inode = filep->f_inode;
+  FAR uint8_t *buffer;
+  size_t remaining;
   ssize_t ntotal;
   ssize_t nread;
-  size_t remaining;
-  FAR uint8_t *buffer;
   int i;
 
-  DEBUGASSERT(inode->u.i_ops->read != NULL);
-

Review Comment:
   Done



##########
fs/vfs/fs_write.c:
##########
@@ -51,15 +51,13 @@
  ****************************************************************************/
 
 static ssize_t file_writev_compat(FAR struct file *filep,
-                                  FAR struct uio *uio)
+                                  FAR const struct iovec *iov, int iovcnt)
 {
-  FAR const struct iovec *iov = uio->uio_iov;
-  int iovcnt = uio->uio_iovcnt;
   FAR struct inode *inode = filep->f_inode;
-  ssize_t ntotal;
+  FAR uint8_t *buffer;
   ssize_t nwritten;
   size_t remaining;
-  FAR uint8_t *buffer;
+  ssize_t ntotal;

Review Comment:
   Done



##########
fs/vfs/fs_write.c:
##########
@@ -95,16 +93,6 @@ static ssize_t file_writev_compat(FAR struct file *filep,
         {
           return ntotal;
         }
-

Review Comment:
   Done



##########
fs/vfs/fs_uio.c:
##########
@@ -81,9 +81,9 @@ ssize_t uio_calc_resid(FAR const struct uio *uio)
 
 void uio_advance(FAR struct uio *uio, size_t sz)
 {
+  size_t offset_in_iov = uio->uio_offset_in_iov;

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org