xiaoxiang781216 commented on code in PR #15561:
URL: https://github.com/apache/nuttx/pull/15561#discussion_r1921100260
##########
include/nuttx/sched.h:
##########
@@ -547,7 +547,8 @@ struct task_group_s
struct mm_map_s tg_mm_map; /* Task group virtual memory mappings */
- spinlock_t tg_lock; /* lock */
+ spinlock_t tg_lock; /* SpinLock for group */
+ mutex_t tg_mutex; /* Mutex for group */
Review Comment:
let's create a new patch to remove tg_joinlock
##########
sched/group/group_create.c:
##########
@@ -223,6 +223,7 @@ void group_postinitialize(FAR struct task_tcb_s *tcb)
DEBUGASSERT(tcb && tcb->cmn.group);
group = tcb->cmn.group;
spin_lock_init(&group->tg_lock);
+ nxmutex_init(&group->tg_mutex);
Review Comment:
where do we call nxmutex_destroy
##########
sched/timer/timer_initialize.c:
##########
@@ -134,21 +134,34 @@ void timer_deleteall(pid_t pid)
{
FAR struct posix_timer_s *timer;
FAR struct posix_timer_s *next;
+ sq_queue_t del_list;
Review Comment:
```suggestion
sq_queue_t freetimers;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
