raiden00pl commented on issue #15567: URL: https://github.com/apache/nuttx/issues/15567#issuecomment-2599645080
+1 for common bittiming calculation interface. Names with `nx_` prefix are OK. The only problem I see now is where to place such a common interface that must be shared across chardev and socketcan implementation ? We already had a PR that tries to generalize some of the code in CAN implementations, but it got stuck: https://github.com/apache/nuttx/pull/14759 I proposed there `include/nuttx/can_cmn.h` for common header but we need also place for common code, probably `drivers/can/can_cmn.c` will be enough. Previously `/drivers/can` was reserved for chardev implementation, but since we support PCI CAN cards in this directory that use both CAN interface - this is no longer valid. I don't see a better place for this kind of code. > CTU CAN FD bittiming and changes I agree, but we need someone who could verify if the changes work on real HW. Personally, I don't have access to any CTU CAN FD hardware. Implementation without any verification on real device makes no sense to me. Are there any commercially available PCI cards with this IP core? Playing with FPGA is out of the question for me at the moment :) > SJA1000 Also agree, but again - we need someone who could verify all changes on different hardware with SAJ1000: 1. ESP implementation, 2. FPGA implementation, 3. PCI implementation. This is quite difficult for one person and also difficult to coordinate several people in the project who could help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
