yf13 commented on code in PR #15588: URL: https://github.com/apache/nuttx/pull/15588#discussion_r1920106080
########## libs/libc/modlib/gnu-elf.ld.in: ########## @@ -26,7 +26,11 @@ # include <nuttx/addrenv.h> # define TEXT CONFIG_ARCH_TEXT_VBASE -# define DATA CONFIG_ARCH_DATA_VBASE + CONFIG_MM_PGSIZE +# ifdef CONFIG_ARCH_ARMV7A +# define DATA CONFIG_ARCH_DATA_VBASE + ARCH_DATA_RESERVE_SIZE Review Comment: Maybe we can unify the `gnu-elf.ld.in` for now and take time to review armv7-a later, see the updated version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
