yamt commented on code in PR #15586:
URL: https://github.com/apache/nuttx/pull/15586#discussion_r1919534472


##########
sched/wqueue/kwork_queue.c:
##########
@@ -80,6 +79,7 @@ static void work_timer_expiry(wdparm_t arg)
     }
 
   spin_unlock_irqrestore(&work->wq->lock, flags);
+  sched_unlock();

Review Comment:
   do these locks need to be released in this order for some reasons?
   otherwise, it's more natural to release them in the reverse order of 
acquiring them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to