nuttxpr commented on PR #15587: URL: https://github.com/apache/nuttx/pull/15587#issuecomment-2597403731
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary (albeit a brief one), it completely neglects the detailed explanations requested in the template. Here's a breakdown of what's missing: * **Summary:** Lacks crucial details. While the title gives a general idea, it doesn't explain *why* this change is necessary. What problem does it solve? What are the benefits of reducing the `sched_lock` range? How exactly is the range being reduced? A related issue number should also be included if one exists. * **Impact:** Simply stating "N/A" is insufficient. The author needs to explicitly consider and address each impact point, even if the answer is "NO". For example, they should explicitly state "Impact on user: NO", "Impact on build: NO", etc., with brief justifications where relevant. Even seemingly minor changes can have unforeseen consequences, so this section is crucial for reviewers. * **Testing:** "ci-check" is insufficient. While CI is helpful, it's not a substitute for providing specific testing details. The author needs to specify the host and target environments used for testing and provide *actual* testing logs before and after the change, demonstrating the improvement. Simply stating "ci-check" doesn't provide reviewers with enough information to evaluate the change effectively. The author needs to substantially revise the PR description to meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
