JianyuWang0623 commented on code in PR #15578: URL: https://github.com/apache/nuttx/pull/15578#discussion_r1918317972
########## libs/libc/misc/lib_tempbuffer.c: ########## @@ -114,6 +114,7 @@ FAR char *lib_get_tempbuffer(size_t nbytes) #ifdef CONFIG_LIBC_TEMPBUFFER_MALLOC return lib_malloc(nbytes); #else + set_errno(ENOMEM); Review Comment: > > All set_errno doesn't add `#if defined`, why do you suggest add it here @anchao ? > > Because this API is special, both the kernel and user space will call this API. If in kernel mode, there is no need to set this errno, UAPI will handle such errors. Maybe we should add check to existing kernel codes(or other ways) for all at once ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
