hujun260 commented on code in PR #15130:
URL: https://github.com/apache/nuttx/pull/15130#discussion_r1912757784
##########
drivers/note/note_driver.c:
##########
@@ -1393,10 +1393,12 @@ void sched_note_irqhandler(int irq, FAR void *handler,
bool enter)
void sched_note_wdog(uint8_t event, FAR void *handler, FAR const void *arg)
{
FAR struct note_driver_s **driver;
+ irqstate_t flags;
struct note_wdog_s note;
bool formatted = false;
FAR struct tcb_s *tcb = this_task();
+ flags = enter_critical_section_wo_note();
Review Comment:
yes, sched_note_wdog should be call in enter_critical_section
g_note_drivers protected by critical_section.
The external critical section protection for sched_note_wdog has been
removed.
##########
drivers/note/note_driver.c:
##########
@@ -1393,10 +1393,12 @@ void sched_note_irqhandler(int irq, FAR void *handler,
bool enter)
void sched_note_wdog(uint8_t event, FAR void *handler, FAR const void *arg)
{
FAR struct note_driver_s **driver;
+ irqstate_t flags;
struct note_wdog_s note;
bool formatted = false;
FAR struct tcb_s *tcb = this_task();
+ flags = enter_critical_section_wo_note();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
